Do not install docs #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new bazel rule entry to create libguestfs-tools rpm tree used to build the container image. Bazel doesn't run post installation steps. Hence, the kernel, rootfs and initrd for libguestfs are not correctly generated. In order to supply them, we can generate the appliance externally and then set the LIBGUESTFS_PATH to point to the generated appliance. Added the makefile rule to generate libguestfs appliance. Signed-off-by: Alice Frosi <[email protected]>
Libguestfs offers a series of tools for debugging and customize disk images. The guestfs command:
- starts a pod with libguestfs-tools
- mounts the pvc under /disks (for filesystem based disks) or /dev/vda (for
block based disks)
- attach stdin/out of the container
- once the user exits from the container, it removes the libguestfs pod
Signed-off-by: Alice Frosi <[email protected]>
Signed-off-by: Alice Frosi <[email protected]>
Small tweak to the yum/dnf command not to install documentation.
alicefr
force-pushed
the
libguestfs-integration-v2
branch
8 times, most recently
from
cdfc4df to
65df419
Compare
|
@mykaul my bad, I really missed this and saw now by chance. Could you please open this against: https://github.com/kubevirt/libguestfs-appliance |
alicefr
force-pushed
the
libguestfs-integration-v2
branch
16 times, most recently
from
baf6d2a to
8efc6d8
Compare
alicefr
force-pushed
the
libguestfs-integration-v2
branch
from
8efc6d8 to
d142507
Compare
alicefr
force-pushed
the
libguestfs-integration-v2
branch
21 times, most recently
from
60891a8 to
f9e4a25
Compare
alicefr
force-pushed
the
libguestfs-integration-v2
branch
4 times, most recently
from
75dd644 to
42c1ea7
Compare
alicefr
force-pushed
the
libguestfs-integration-v2
branch
5 times, most recently
from
5e01831 to
dc81359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweak to the yum/dnf command not to install documentation.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: