feat: check that async_early_return is applied on async functions

[fgsalomon]

No description provided.

[fgsalomon]

To me this should be handled by custom lint rules but ruff still doesn't provide a plugin system like flake8 does.

[acostapazo]

To me this should be handled by custom lint rules but astral-sh/ruff#283 like flake8 does.

Yes, in the meantime, we can apply solutions similar to what you proposed. We should also implement something similar onearly_return in async functions.

Should we return a Failure(AsyncDecorationError()) or maybe we just raise an exception and stop the runtime as we do in https://github.com/alice-biometrics/meiga/blob/main/meiga/result.py#L69

[acostapazo]

Otherwise, you have followed the same definition as UnexpectedDecorationOrderError, UnexpectedDecorationOrderError so probably it is ok 🤔

         if isinstance(func, staticmethod):
                return Failure(UnexpectedDecorationOrderError())  # type: ignore
            elif isinstance(func, classmethod):
                return Failure(UnexpectedDecorationOrderError())  # type: ignore
            elif not inspect.iscoroutinefunction(func):
                return Failure(AsyncDecorationError())  # type: ignore

[fgsalomon]

Otherwise, you have followed the same definition as UnexpectedDecorationOrderError, UnexpectedDecorationOrderError so probably it is ok 🤔

         if isinstance(func, staticmethod):
                return Failure(UnexpectedDecorationOrderError())  # type: ignore
            elif isinstance(func, classmethod):
                return Failure(UnexpectedDecorationOrderError())  # type: ignore
            elif not inspect.iscoroutinefunction(func):
                return Failure(AsyncDecorationError())  # type: ignore

I was going to throw an exception but I saw that and followed suit.

[fgsalomon]

I guess we can use custom code inspections in PyCharm to detect this kind of things:

[fgsalomon]

To me this should be handled by custom lint rules but ruff still doesn't provide a plugin system like flake8 does.

I've just discovered Fixit. I think it should be easy to write a custom rule with it.