Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* [jsfm] fix undefined for element's depth #10

Merged
merged 1 commit into from
Apr 16, 2016

Conversation

terrykingcha
Copy link
Contributor

for a example

<template>
  <container append="tree">
    <text repeat="{{list}}">{{text}}</text>
  </container>
</template>

<script>
module.exports = {
  data: {
    list: []
  },
  created: function() {
    someAsyncMethod(function() {
       this.list.push({text: 123})
    })
  }
}
</script>

will cause undefined for fragBlock.element.depth when calling _watchBlock in lib/vm/compiler.js.

so, just set 0 by default to fix it.

@Jinjiang Jinjiang merged commit 38d758c into jsfm Apr 16, 2016
@Jinjiang Jinjiang deleted the bugfix-jsfm-elementDepth branch April 16, 2016 05:13
@Jinjiang
Copy link
Contributor

Btw, the branch format should be jsfm-bugfix-element-depth. jsfm first and no upper case, no underline.

Jinjiang added a commit that referenced this pull request Apr 17, 2016
* [jsfm] fix undefined for element's depth
Jinjiang added a commit that referenced this pull request Apr 20, 2016
* [jsfm] fix undefined for element's depth
@terrykingcha terrykingcha added this to the 0530 milestone Apr 27, 2016
Tancy pushed a commit to Tancy/weex that referenced this pull request Mar 23, 2017
…y-type

+ [html5] input and textarea enter key type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants