fallback Method throw exception but seata does not rollback #3786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
i use seata to perform global transaction, use openfeign to invoke other microservice, and use sentinel to do fallbacks. in my fallback method if i throw an customerized Exception, this exception will be wrapped into
AssertionError
, then seata will not rollback correctly, beacuse seate only rollback for Exception defined in @GlobalTransactional(rollbackFor=Exception.class).Does this pull request fix one issue?
yes
Describe how you did it
when i throw the original excetion, seata rollbacks correctly
Describe how to verify it
throw new RuntimeException('wharever') in fallback method, seata rollbacks correctly
Special notes for reviews