Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adapter for iris web framework #524

Merged
merged 7 commits into from
Apr 17, 2023

Conversation

Alipebt
Copy link
Contributor

@Alipebt Alipebt commented Apr 14, 2023

Describe what this PR does / why we need it

Add adapter for https://github.com/kataras/iris

Does this pull request fix one issue?

Fixes #485

Alipebt added 5 commits April 14, 2023 18:12
Signed-off-by: Alipebt <[email protected]>
Signed-off-by: Alipebt <[email protected]>
Signed-off-by: Alipebt <[email protected]>
Signed-off-by: Alipebt <[email protected]>
Signed-off-by: Alipebt <[email protected]>
@sczyh30 sczyh30 added the area/integrations Issue related to integrations with open-source components label Apr 16, 2023
@sczyh30 sczyh30 requested review from sczyh30 and binbin0325 April 16, 2023 08:04
@Alipebt
Copy link
Contributor Author

Alipebt commented Apr 16, 2023

@sczyh30 Hello, I have used the unit test to test the adapter, and I have not found any problems so far. But I don't know what caused the error in the ci test, and it seems that it has nothing to do with the code I wrote. Could you give me some advice?

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 7b454db into alibaba:master Apr 17, 2023
@sczyh30
Copy link
Member

sczyh30 commented Apr 17, 2023

Thanks for contributing! The CI problem might be fixed by #500

@sczyh30 sczyh30 added the kind/feature Category issues or PRs related to feature request label Apr 17, 2023
binbin0325 pushed a commit to binbin0325/sentinel-golang that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations Issue related to integrations with open-source components kind/feature Category issues or PRs related to feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Integration] Add adapter for Iris web framework
3 participants