Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circuit breaker supported probe number #428

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

binbin0325
Copy link
Collaborator

Describe what this PR does / why we need it
circuit breaker support probes num

Does this pull request fix one issue?
fix:#411

Describe how you did it
Provides the probe count configuration to match the probe count when the circuit breaker is half-open

Describe how to verify it
Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2021

Codecov Report

Merging #428 (1bc1818) into master (671274f) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
+ Coverage   53.43%   53.53%   +0.09%     
==========================================
  Files          89       89              
  Lines        5820     5841      +21     
==========================================
+ Hits         3110     3127      +17     
- Misses       2361     2366       +5     
+ Partials      349      348       -1     
Impacted Files Coverage Δ
core/circuitbreaker/rule.go 51.16% <ø> (-13.96%) ⬇️
core/circuitbreaker/circuit_breaker.go 74.67% <100.00%> (+2.02%) ⬆️
core/stat/base/leap_array.go 72.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 671274f...1bc1818. Read the comment docs.

@sczyh30 sczyh30 added area/circuit-breaking Issues or PRs related to circuit breaking to-review PRs to review labels Sep 13, 2021
@sczyh30 sczyh30 added the kind/enhancement Category issues or PRs related to enhancement label Nov 16, 2021
core/circuitbreaker/circuit_breaker.go Outdated Show resolved Hide resolved
core/circuitbreaker/circuit_breaker.go Outdated Show resolved Hide resolved
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30
Copy link
Member

sczyh30 commented Dec 6, 2021

@louyuting @luckyxiaoqiang @liqiangz Any other comments?

@sczyh30 sczyh30 merged commit 9eabe9f into alibaba:master Dec 11, 2021
@sczyh30 sczyh30 added kind/feature Category issues or PRs related to feature request and removed to-review PRs to review labels Dec 11, 2021
@sczyh30
Copy link
Member

sczyh30 commented Dec 11, 2021

Nice work. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/circuit-breaking Issues or PRs related to circuit breaking kind/enhancement Category issues or PRs related to enhancement kind/feature Category issues or PRs related to feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Circuit breaker half-open probe strategy | 熔断half-open恢复时支持配置探测次数
3 participants