-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data race bug: In concurrency scenario, RegisterRuleCheckSlotForResource and Entry will compete the slots in SlotChain #337
Conversation
f2b7811
to
811cacc
Compare
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 50.75% 50.83% +0.07%
==========================================
Files 69 69
Lines 3822 3842 +20
==========================================
+ Hits 1940 1953 +13
- Misses 1614 1621 +7
Partials 268 268
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
fbfb398
811cacc
to
fbfb398
Compare
…race on the slots in SlotChain between RegisterRuleCheckSlotForResource and Entry function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe what this PR does / why we need it
Does this pull request fix one issue?
"Fixes #335 "
"Fixes #336 "
Describe how you did it
Describe how to verify it
run unit test
Special notes for reviews