Fix bugs of throttling control behavior in flow control module #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczyh30
added
kind/bug
|
Also cc @NineSunRD @luckyxiaoqiang @sanxun0325 |
louyuting
reviewed
Nov 25, 2020
…lated stat slots Signed-off-by: Eric Zhao <[email protected]>
…cker may overflow * Use int64 instead of uint64 here * Update wait duration to nanos Signed-off-by: Eric Zhao <[email protected]>
sczyh30
force-pushed
the
fix-throttling-overflow
branch
from
6a0224b to
d443d80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Fix bugs of throttling control behavior in flow control module, including overflow bug and time unit bug of wait duration.
Does this pull request fix one issue?
Fixes #331
Describe how you did it
waitMstonanosToWaitinTokenResultand polish related stat slots. Here we SHOULD use nanos instead of millis, or the queueing interval may not be accurate.estimatedQueueingDurationin throttling checker may overflow. Use int64 instead.Describe how to verify it
Run the test cases and demo.
Special notes for reviews
NONE.