Enhance config API, support initialization by config parser #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louyuting
added
the
area/configuration
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 51.52% 51.44% -0.08%
==========================================
Files 80 80
Lines 4004 4010 +6
==========================================
Hits 2063 2063
- Misses 1655 1661 +6
Partials 286 286
Continue to review full report at Codecov.
|
louyuting
force-pushed
the
20201014-enhance-config-api
branch
from
ded1e3d
to
6e6fcc0
Compare
louyuting
force-pushed
the
20201014-enhance-config-api
branch
from
6e6fcc0
to
873beb4
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
func InitWithParser(configBytes []byte, parser func([]byte) (*config.Entity, error)) (err error)to initialize SentinelDoes this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews