Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine circuit breaker state atomic operation #276

Merged
merged 4 commits into from
Oct 11, 2020
Merged

Refine circuit breaker state atomic operation #276

merged 4 commits into from
Oct 11, 2020

Conversation

AlexStocks
Copy link
Contributor

Describe what this PR does / why we need it

using cb state in go way

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

luckyxiaoqiang
luckyxiaoqiang previously approved these changes Oct 11, 2020
View reviewed changes
Copy link
Collaborator

@luckyxiaoqiang luckyxiaoqiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@louyuting louyuting self-requested a review October 11, 2020 15:52
@louyuting louyuting added the kind/enhancement Category issues or PRs related to enhancement label Oct 11, 2020
@louyuting louyuting added this to the 1.0.0 milestone Oct 11, 2020
louyuting
louyuting previously approved these changes Oct 11, 2020
View reviewed changes
Copy link
Collaborator

@louyuting louyuting left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@codecov-io
Copy link

codecov-io commented Oct 11, 2020 •
edited
Loading

Codecov Report

Merging #276 into master will decrease coverage by 0.10%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   51.45%   51.34%   -0.11%     
==========================================
  Files          79       79              
  Lines        4033     4024       -9     
==========================================
- Hits         2075     2066       -9     
  Misses       1668     1668              
  Partials      290      290
Impacted Files Coverage Δ
core/circuitbreaker/circuit_breaker.go 68.15% <92.85%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908210d...6d3c9a4. Read the comment docs.

@louyuting louyuting merged commit 2c7107c into alibaba:master Oct 11, 2020
@sczyh30 sczyh30 changed the title Imp: cb state Refine circuit breaker state atomic operation Oct 12, 2020
linyihai pushed a commit to linyihai/sentinel-golang that referenced this pull request Oct 13, 2020
@AlexStocks @louyuting @linyihai
refine circuit breaker State atomic operation (alibaba#276)
f24b0ad 
* refine circuit breaker State atomic operation

Co-authored-by: louyuting <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luckyxiaoqiang luckyxiaoqiang luckyxiaoqiang left review comments

@louyuting louyuting louyuting approved these changes

Assignees
No one assigned
Labels
kind/enhancement Category issues or PRs related to enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexStocks @CLAassistant @codecov-io @louyuting @luckyxiaoqiang