Flow rule cache/check #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
==========================================
+ Coverage 50.41% 50.51% +0.09%
==========================================
Files 68 68
Lines 3709 3716 +7
==========================================
+ Hits 1870 1877 +7
Misses 1577 1577
Partials 262 262
Continue to review full report at Codecov.
|
binbin0325
force-pushed
the
flow_rule_cache20201007
branch
from
ff71204 to
1d33289
Compare
binbin0325
force-pushed
the
flow_rule_cache20201007
branch
3 times, most recently
from
cb8293e to
3682e31
Compare
louyuting
added
area/flow-control
louyuting
force-pushed
the
flow_rule_cache20201007
branch
from
3682e31 to
33d59eb
Compare
sczyh30
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
In order to avoid the meaningless updates to the property, downstream of property manager should
cache last update value to check consistency.
Does this pull request fix one issue?
Fix:#111
Describe how you did it
Using reflect.deepequal,maybe we need to think about performance
Describe how to verify it
ut
Special notes for reviews