Refine GetResRule API and GetRules API in flow/circuitbreaker/hotspot/system module #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 42.93% 42.64% -0.29%
==========================================
Files 74 74
Lines 4316 4345 +29
==========================================
Hits 1853 1853
- Misses 2230 2259 +29
Partials 233 233
Continue to review full report at Codecov.
|
louyuting
added
area/flow-control
louyuting
changed the title
sczyh30
reviewed
Sep 14, 2020
core/circuitbreaker/rule_manager.go
Outdated
| // It doesn't take effect for circuit breaker module if user changes the rule. | ||
| // GetResRules need to compete circuit breaker module's global lock and the high performance losses of copy, | ||
| // reduce or do not call GetResRules frequently if possible | ||
| func GetResRules(resource string) []Rule { |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Refine GetResRule func and GetRules func in flow/circuitbreaker/hotspot/system module
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews