Improve Config API #238
Merged
Improve Config API #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louyuting
added
area/configuration
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
- Coverage 42.93% 42.53% -0.40%
==========================================
Files 74 74
Lines 4316 4356 +40
==========================================
Hits 1853 1853
- Misses 2230 2271 +41
+ Partials 233 232 -1
Continue to review full report at Codecov.
|
sczyh30
reviewed
Sep 14, 2020
sczyh30
reviewed
Sep 14, 2020
logging/logging.go
Outdated
| func init() { | ||
| defaultFileLogger, err := NewSimpleFileLogger(GetDefaultLogDir()+RecordLogFileName, DefaultNamespace, 0) | ||
| if err != nil { | ||
| globalLogger.Error("fail to init global file logger") |
louyuting
force-pushed
the
20200911-refine-api
branch
from
0692b30 to
16ad305
Compare
sczyh30
approved these changes
Sep 16, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Improve sentinel initialization mechanism
Does this pull request fix one issue?
None
Describe how you did it
Describe how to verify it
UT
Special notes for reviews
@sczyh30