Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove field LimitOrigin in flow.Rule #233

Merged

Conversation

louyuting
Copy link
Collaborator

Describe what this PR does / why we need it

Remove field LimitOrigin in flow.Rule B/C LimitOrigin is redundancy

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

CI passs

Special notes for reviews

@louyuting louyuting requested a review from sczyh30 September 8, 2020 03:17
@louyuting louyuting added area/flow-control Issues or PRs related to flow control kind/enhancement Category issues or PRs related to enhancement labels Sep 8, 2020
@louyuting louyuting added this to the 0.6.1 milestone Sep 8, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2020

Codecov Report

Merging #233 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   42.13%   42.11%   -0.03%     
==========================================
  Files          79       79              
  Lines        4369     4367       -2     
==========================================
- Hits         1841     1839       -2     
  Misses       2294     2294              
  Partials      234      234              
Impacted Files Coverage Δ
core/flow/rule.go 0.00% <ø> (ø)
core/flow/rule_manager.go 50.80% <ø> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19792ae...83bfdd3. Read the comment docs.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 3c6af56 into alibaba:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/flow-control Issues or PRs related to flow control kind/enhancement Category issues or PRs related to enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants