Refine API and exported structure naming in core pkg #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
==========================================
+ Coverage 42.35% 42.93% +0.58%
==========================================
Files 79 74 -5
Lines 4446 4316 -130
==========================================
- Hits 1883 1853 -30
+ Misses 2329 2230 -99
+ Partials 234 233 -1
Continue to review full report at Codecov.
|
louyuting
added
area/document
louyuting
changed the title
sczyh30
reviewed
Sep 8, 2020
api/doc.go
Outdated
| @@ -0,0 +1,51 @@ | |||
| // Package api is the topmost API interface package for users using sentinel-golang(aka sentinel) | |||
| // | |||
| // Users must initialize sentinel before loading sentinel rules. Sentinel support three ways to perform initialization: | |||
There was a problem hiding this comment.
sentinel -> Sentinel (in all cases as a brand)
api/doc.go
Outdated
| @@ -0,0 +1,51 @@ | |||
| // Package api is the topmost API interface package for users using sentinel-golang(aka sentinel) | |||
There was a problem hiding this comment.
The first sentence should end with .
api/doc.go
Outdated
| // log.Fatal(err) | ||
| // } | ||
| // | ||
| // //Load sentinel rules |
There was a problem hiding this comment.
The example might be too complicated? Actually we may introduce APIs in this package.
remove unused code
louyuting
force-pushed
the
20200907-refine-API
branch
from
8205e8b to
470b85a
Compare
louyuting
changed the title
sczyh30
approved these changes
Sep 8, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Refine API and exported structure naming in core pkg
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews