Break down flow.ControlBehavior to flow.TokenCalculateStrategy and flow.ControlBehavior #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
+ Coverage 42.11% 42.35% +0.24%
==========================================
Files 79 79
Lines 4367 4446 +79
==========================================
+ Hits 1839 1883 +44
- Misses 2294 2329 +35
Partials 234 234
Continue to review full report at Codecov.
|
louyuting
force-pushed
the
20200903-breakdown-flow-ControlBehavior
branch
from
6774d36
to
4f770ad
Compare
louyuting
force-pushed
the
20200903-breakdown-flow-ControlBehavior
branch
from
45a24e9
to
8c472a8
Compare
louyuting
added
area/flow-control
sczyh30
reviewed
Sep 3, 2020
core/flow/rule.go
Outdated
|
|
||
| const ( | ||
| Reject ControlBehavior = iota | ||
| Default AllocationStrategy = iota |
There was a problem hiding this comment.
The naming had been updated.
How do you think of?
louyuting
force-pushed
the
20200903-breakdown-flow-ControlBehavior
branch
from
8c472a8
to
c05d483
Compare
louyuting
changed the title
louyuting
force-pushed
the
20200903-breakdown-flow-ControlBehavior
branch
from
b9a6a38
to
e439882
Compare
louyuting
changed the title
louyuting
force-pushed
the
20200903-breakdown-flow-ControlBehavior
branch
from
3110e48
to
0fec6ae
Compare
…ow.ControlBehavior
louyuting
force-pushed
the
20200903-breakdown-flow-ControlBehavior
branch
from
0fec6ae
to
aee8d68
Compare
sczyh30
reviewed
Sep 8, 2020
core/flow/rule.go
Outdated
| // Direct means flow control by current resource directly. | ||
| Direct RelationStrategy = iota | ||
| // DirectResource means flow control by current resource directly. | ||
| DirectResource RelationStrategy = iota |
There was a problem hiding this comment.
DirectResource seems confusing. Maybe "CurrentResource`?
sczyh30
approved these changes
Sep 8, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Break down flow.ControlBehavior to flow.AllocationStrategy and flow.ControlEffect
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews