Refine the semantics of StatSlot onComplete #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczyh30
reviewed
Aug 26, 2020
core/base/slot_chain.go
Outdated
| for _, s := range sc.stats { | ||
| // The OnCompleted is called only when entry passed | ||
| if ctx.IsBlocked() { |
There was a problem hiding this comment.
Maybe just checking it outside is better?
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
+ Coverage 42.41% 42.58% +0.16%
==========================================
Files 82 82
Lines 4406 4405 -1
==========================================
+ Hits 1869 1876 +7
+ Misses 2297 2289 -8
Partials 240 240
Continue to review full report at Codecov.
|
|
Thanks for contributing! |
sczyh30
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Make StatSlot.OnCompleted sense
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Ut
Special notes for reviews