-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the inveracious logging.Logger to customize. #201
Conversation
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
- Coverage 44.25% 43.99% -0.27%
==========================================
Files 80 80
Lines 4424 4453 +29
==========================================
+ Hits 1958 1959 +1
- Misses 2236 2264 +28
Partials 230 230
Continue to review full report at Codecov.
|
Thanks for the fix, I think it is basically available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice work. Thanks! |
Describe what this PR does / why we need it
In logging module, current implementation cannot customize Logger implementation by user.
Current exported function, logging.ResetDefaultLogger(), is not working as expected.
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews