Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade nacos sdk #199

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Conversation

binbin0325
Copy link
Collaborator

Describe what this PR does / why we need it

Upgrade nacos-sdk-go v1.0.0

This version optimizes a lot of things, especially config file listening and canceling。

Describe how to verify it

go test ./...

Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #199 into master will decrease coverage by 0.06%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   44.70%   44.64%   -0.07%     
==========================================
  Files          80       80              
  Lines        4438     4442       +4     
==========================================
- Hits         1984     1983       -1     
- Misses       2227     2232       +5     
  Partials      227      227              
Impacted Files Coverage Δ
ext/datasource/nacos/nacos.go 51.72% <40.00%> (-5.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c93bfd8...a7cae97. Read the comment docs.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 4541288 into alibaba:master Aug 4, 2020
@sczyh30
Copy link
Member

sczyh30 commented Aug 4, 2020

Thanks for contributing!

@sczyh30 sczyh30 added the area/data-source Issues or PRs related to data-source extension label Aug 4, 2020
@louyuting louyuting added this to the 0.6.0 milestone Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-source Issues or PRs related to data-source extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants