Optimize the way to initialize the start time of the AtomicBucketWrapArray #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louyuting
added
kind/bug
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 44.70% 44.80% +0.09%
==========================================
Files 80 80
Lines 4438 4464 +26
==========================================
+ Hits 1984 2000 +16
- Misses 2227 2235 +8
- Partials 227 229 +2
Continue to review full report at Codecov.
|
sczyh30
reviewed
Aug 3, 2020
core/stat/base/leap_array.go
Outdated
| startTime := calculateStartTime(util.CurrentTimeMillis(), bucketLengthInMs) | ||
| for i := len - 1; i >= 0; i-- { | ||
| interval := uint64(bucketLengthInMs * uint32(len)) | ||
| arrayStartTime := now - (now % interval) |
There was a problem hiding this comment.
The startTime for current idx should be now - now % bucketLengthInMs?
For example (in related test cases), sampleCount=10, bucketLength=200ms, now=1596199317921, then the oldest bucket of created data structure should be 1596199317800
louyuting
force-pushed
the
20200801-enhance-stat
branch
3 times, most recently
from
843cda6
to
0489375
Compare
louyuting
force-pushed
the
20200801-enhance-stat
branch
from
3c2dfea
to
da12b0c
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Make the start time of AtomicBucketWrapArray align to standard time.
Fix the typo in NewLeapArray.
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews