Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carry invocation arguments in filters of Dubbo adapter #186

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

sczyh30
Copy link
Member

@sczyh30 sczyh30 commented Jul 23, 2020

Signed-off-by: Eric Zhao [email protected]

Describe what this PR does / why we need it

Carry invocation arguments in filters of Dubbo adapter.

Does this pull request fix one issue?

Related to #181

@sczyh30 sczyh30 added the area/integrations Issue related to integrations with open-source components label Jul 23, 2020
@sczyh30 sczyh30 requested a review from louyuting July 23, 2020 06:14
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020

Codecov Report

Merging #186 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   44.81%   44.83%   +0.02%     
==========================================
  Files          80       80              
  Lines        4432     4434       +2     
==========================================
+ Hits         1986     1988       +2     
  Misses       2219     2219              
  Partials      227      227              
Impacted Files Coverage Δ
adapter/dubbo/consumer_filter.go 50.00% <100.00%> (+1.61%) ⬆️
adapter/dubbo/provider_filter.go 50.00% <100.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d51b06d...ea26682. Read the comment docs.

@louyuting louyuting merged commit 1f1c71b into alibaba:master Jul 24, 2020
@sczyh30 sczyh30 deleted the polish-adapters-0723 branch July 28, 2020 02:44
@sczyh30 sczyh30 added this to the 0.5.0 milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations Issue related to integrations with open-source components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants