Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotspot Enhancement and bug fix in AtomicBucketWrapArray #185

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

louyuting
Copy link
Collaborator

@louyuting louyuting commented Jul 21, 2020

Describe what this PR does / why we need it

Does this pull request fix one issue?

Fixes #166

Describe how you did it

Describe how to verify it

Special notes for reviews

@louyuting
Copy link
Collaborator Author

@sczyh30 Please use "rebase and commit"

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2020

Codecov Report

Merging #185 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   44.75%   44.76%   +0.01%     
==========================================
  Files          78       78              
  Lines        4353     4352       -1     
==========================================
  Hits         1948     1948              
+ Misses       2186     2185       -1     
  Partials      219      219              
Impacted Files Coverage Δ
core/hotspot/slot.go 33.33% <ø> (+0.37%) ⬆️
core/stat/base/leap_array.go 57.14% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed802d3...7e223e6. Read the comment docs.

@sczyh30 sczyh30 added the kind/enhancement Category issues or PRs related to enhancement label Jul 22, 2020
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit a149984 into alibaba:master Jul 22, 2020
@sczyh30
Copy link
Member

sczyh30 commented Jul 22, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or PRs related to enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support arbitrary param type in "hot spot" parameter flow control
3 participants