Loading circuitbreaker rule supports cache

core/circuitbreaker/rule_manager.go

@@ -19,6 +19,7 @@ var (
 	breakerRules = make(map[string][]*Rule)
 	breakers     = make(map[string][]CircuitBreaker)
 	updateMux    = &sync.RWMutex{}
+	currentRules = make([]*Rule, 0)
 
 	stateChangeListeners = make([]StateChangeListener, 0)
 )
@@ -117,6 +118,14 @@ func ClearRules() error {
 // error: was designed to indicate whether occurs the error.
 func LoadRules(rules []*Rule) (bool, error) {
 	// TODO in order to avoid invalid update, should check consistent with last update rules
+	updateMux.RLock()
+	isEqual := reflect.DeepEqual(currentRules, rules)
+	updateMux.RUnlock()
+	if isEqual {
+		logging.Info("[CircuitBreaker] Load rules repetition, does not load")
+		return false, nil
+	}
+
 	err := onRuleUpdate(rules)
 	return true, err
 }
@@ -271,6 +280,8 @@ func onRuleUpdate(rules []*Rule) (err error) {
 
 	breakerRules = newBreakerRules
 	breakers = newBreakers
+	currentRules = rules
+
 	return nil
 }
 

core/circuitbreaker/rule_manager_test.go

@@ -340,3 +340,33 @@ func TestRemoveCircuitBreakerGenerator(t *testing.T) {
 		assert.Error(t, err, "not allowed to remove the generator for default circuit breaking strategies")
 	})
 }
+
+func TestLoadRules(t *testing.T) {
+	t.Run("loadSameRules", func(t *testing.T) {
+		_, err := LoadRules([]*Rule{
+			{
+				Resource:         "abc",
+				Strategy:         SlowRequestRatio,
+				RetryTimeoutMs:   1000,
+				MinRequestAmount: 5,
+				StatIntervalMs:   1000,
+				MaxAllowedRtMs:   20,
+				Threshold:        0.1,
+			},
+		})
+		assert.Nil(t, err)
+		ok, err := LoadRules([]*Rule{
+			{
+				Resource:         "abc",
+				Strategy:         SlowRequestRatio,
+				RetryTimeoutMs:   1000,
+				MinRequestAmount: 5,
+				StatIntervalMs:   1000,
+				MaxAllowedRtMs:   20,
+				Threshold:        0.1,
+			},
+		})
+		assert.Nil(t, err)
+		assert.False(t, ok)
+	})
+}

ext/datasource/helper.go

@@ -139,8 +139,8 @@ func CircuitBreakerRulesUpdater(data interface{}) error {
 			fmt.Sprintf("Fail to type assert data to []*circuitbreaker.Rule, in fact, data: %+v", data),
 		)
 	}
-	succ, err := cb.LoadRules(rules)
-	if succ && err == nil {
+	_, err := cb.LoadRules(rules)
+	if err == nil {
 		return nil
 	}
 	return NewError(