test: add unit test cases for image_proxy_util.go #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 24, 2018 01:09
Signed-off-by: Jerome Tan <[email protected]>
Signed-off-by: Jerome Tan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1786 +/- ##
==========================================
+ Coverage 56.3% 56.67% +0.36%
==========================================
Files 200 200
Lines 15657 15657
==========================================
+ Hits 8816 8873 +57
+ Misses 5745 5692 -53
+ Partials 1096 1092 -4
|
Closed
fuweid
reviewed
Jul 24, 2018
| } | ||
|
|
||
| // simulate the fetch of environmental variable no_proxy | ||
| noProxyEnv.once.Do(func() {}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add unit test cases for
func canonicalAddr()andfunc useProxy()Ⅱ. Does this pull request fix one issue?
Yes, #1760
Ⅲ. Describe how you did it
Implement test cases for all possible scenarios of
func canonicalAddr()andfunc useProxy()Ⅳ. Describe how to verify it
Run
go test ctrd/image_proxy_util_test.goⅤ. Special notes for reviews
Team 10