Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test1 #1880

Closed
Closed

Conversation

zhengshiqiang47
Copy link

@zhengshiqiang47 zhengshiqiang47 commented Jul 24, 2018

Ⅰ. Describe what this PR did

#1760

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

baiji group five

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @zhengshiqiang47
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@pouchrobot
Copy link
Collaborator

@zhengshiqiang47 Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @zhengshiqiang47
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @zhengshiqiang47
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@zhuorantan
Copy link
Contributor

zhuorantan commented Jul 24, 2018

The scenario that the value of environmental variable no_proxy is * is not tested. @Lykosteng Here is a version that include all possible scenarios #1786

@pouchrobot
Copy link
Collaborator

ping @zhengshiqiang47
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

@fuweid fuweid closed this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants