[ISSUE #3192] replace nacos-config module http client #3523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KomachiSion
requested changes
Aug 6, 2020
| String json = result.content; | ||
| SampleResult resultObj = JSONUtils.deserializeObject(json, new TypeReference<SampleResult>() { | ||
| if (result.ok()) { | ||
| return JSONUtils.deserializeObject(result.getData(), new TypeReference<SampleResult>() { |
There was a problem hiding this comment.
Can unified json utils to Jackson util?
| } | ||
| AsyncNotifyCallBack asyncNotifyCallBack = new AsyncNotifyCallBack(task); | ||
| try { | ||
| restTemplate.get(task.url, header, Query.EMPTY, String.class, asyncNotifyCallBack); |
There was a problem hiding this comment.
Should we modified this restTemplate.get method, if any error when execute get, call the callback.onError in the restTemplate.get rather than throw exception?
There was a problem hiding this comment.
Ok, very good advice
…emplate exception handling.
KomachiSion
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
refer： #3192
Brief changelog
Mainly replace the http client used by
com.alibaba.nacos.config.server.service.notify.NotifyServiceandcom.alibaba.nacos.config.server.service.notify.AsyncNotifyService.Verifying this change
Simulate a three-node cluster locally, modify the configuration information on the console, Through debugging, it has been verified that the http client after replacement can work normally.
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.