[ISSUE #2858] Unified http client implementation, enhanced async request callback interface #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maijh97
changed the title
KomachiSion
requested changes
Jul 27, 2020
| @@ -454,7 +454,7 @@ protected void executeBody() { | |||
| try { | |||
| asyncHttpClient | |||
| .post(url, Header.newInstance().addParam(Constants.NACOS_SERVER_HEADER, VersionUtils.version), | |||
| Query.EMPTY, getSelf(), reference.getType(), new Callback<String>() { | |||
| Query.EMPTY, getSelf(), reference.getType(), new AbstractCallback<String>() { | |||
There was a problem hiding this comment.
Why not use interface rather than Abstract class？
| @@ -162,7 +162,7 @@ public NacosClusterController(ServerMemberManager memberManager) { | |||
| final String url = HttpUtils | |||
| .buildUrl(false, member.getAddress(), ApplicationUtils.getContextPath(), Commons.NACOS_CORE_CONTEXT, | |||
| "/cluster/server/leave"); | |||
| asyncHttpClient.post(url, Header.EMPTY, Query.EMPTY, params, genericType.getType(), new Callback<String>() { | |||
| asyncHttpClient.post(url, Header.EMPTY, Query.EMPTY, params, genericType.getType(), new AbstractCallback<String>() { | |||
There was a problem hiding this comment.
Same question as above
| * | ||
| * @author mai.jh | ||
| */ | ||
| public abstract class AbstractCallback<T> implements Callback<T> { |
There was a problem hiding this comment.
An abstract class but without any default implement and no more abstract method?
KomachiSion
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
#2858
Brief changelog
Add
onCancelmethod tocallbackVerifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.