[ISSUE #2856]Adjust the use of thread pools (config module) #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangweizZZ
force-pushed
the
issue_2856_config
branch
from
2754ef6 to
94f6c61
Compare
KomachiSion
requested changes
Jul 13, 2020
| .schedule(new CmdbLabelTask(), switches.getLabelTaskInterval(), TimeUnit.SECONDS); | ||
| UtilsAndCommons.GLOBAL_EXECUTOR | ||
| .schedule(new CmdbEventTask(), switches.getEventTaskInterval(), TimeUnit.SECONDS); | ||
| UtilsAndCommons.scheduleCmdbTask(new CmdbDumpTask(), switches.getDumpTaskInterval(), TimeUnit.SECONDS); |
There was a problem hiding this comment.
Should we create a new class CmdbExecutors like naming and config? Don't put them into UtilsAndCommons
| @@ -30,17 +30,17 @@ | |||
| * @author Nacos | |||
| */ | |||
| @Service | |||
| public class MemoryMonitor { | |||
| class MemoryMonitor { | |||
|
|
||
| public static void scheduleWithFixedDelay(Runnable command, long initialDelay, long delay, TimeUnit unit) { | ||
| private static final ScheduledExecutorService CAPACITY_MANAGEMENT_EXECUTOR = ExecutorFactory.Managed |
There was a problem hiding this comment.
The thread pool factory are different between original and here.
KomachiSion
added
area/Nacos Core
kind/refactor
and removed
pending
wangweizZZ
force-pushed
the
issue_2856_config
branch
from
41cf64c to
eb86f4e
Compare
KomachiSion
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
#2856
Brief changelog
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.