Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue#12569] Enhance is exist table logic to support more database. #12582

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

huangkemingyyds
Copy link
Contributor

@huangkemingyyds huangkemingyyds commented Sep 2, 2024

Fixes #12569

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (209dfe8) to head (6a76e84).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12582      +/-   ##
=============================================
+ Coverage      69.63%   69.65%   +0.02%     
- Complexity      9399     9419      +20     
=============================================
  Files           1275     1275              
  Lines          41161    41226      +65     
  Branches        4366     4373       +7     
=============================================
+ Hits           28663    28717      +54     
- Misses         10422    10428       +6     
- Partials        2076     2081       +5     
Files with missing lines Coverage Δ
...epository/EmbeddedNamespacePersistServiceImpl.java 100.00% <100.00%> (ø)
...epository/ExternalNamespacePersistServiceImpl.java 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 209dfe8...6a76e84. Read the comment docs.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接改成Count(*)整张表会不会有性能问题?

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看了下 应该只有启动的时候执行一次,应该还好。

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Sep 3, 2024
@KomachiSion KomachiSion changed the title Issue 12569 v1 [Issue#12569] Enhance is exist table logic to support more database. Sep 3, 2024
@KomachiSion KomachiSion added this to the 2.4.2 milestone Sep 3, 2024
@KomachiSion KomachiSion merged commit de33667 into alibaba:develop Sep 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement. plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用Oracle数据库运行,启动报错。
3 participants