-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CVE-2024-22243 & CVE-2024-22259 Upgrade Spring Web to 5.3.33 #11833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样的修复方式是否正确?
我理解spring-web应该是基于spring-boot引入的,看下是否能通过升级spring-boot版本来解决?
是由 Spring Boot 引入,目前我看使用的版本是2.7.18,是Spring Boot 2 的最后一个版本。如果升级只能升级为3.0,改动应该比较大。所以我在依赖管理中重新定义了 Spring Web 的版本。 我理解没声明 spring-web 版本时会使用 Spring Boot 依赖的版本,如果声明了版本会使用自己声明的。 |
Now need to upgrade to 5.3.33 to solve simialr CVE |
可以用mvn dependency:tree 看一下修改的是否生效,如果生效的话就这么修改一下。 |
84deabe
to
980750c
Compare
是否直接修改整体的 |
@ICE-GB 我理解社区后期会升到SpringBoot 3.0,这是暂时为了修复CVE的一个方案。目前使用的版本是2.7.18,依赖 spring-framework 5.3.31,升级到5.3.33,相当于修订版本升级,应该没有兼容问题。 |
如果是暂时性修复那没什么问题,主要是单独一个依赖放在那里,可能会被其他开发人员忽略,导致后续升级时忘掉这个东西 |
What is the purpose of the change
Closes #11811
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.