Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #11595]fix user update permission #11603

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

godhth
Copy link
Contributor

@godhth godhth commented Jan 8, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #11595

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (dbb1b65) 64.08% compared to head (a1b2c71) 64.06%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11603      +/-   ##
=============================================
- Coverage      64.08%   64.06%   -0.02%     
- Complexity      7102     7105       +3     
=============================================
  Files           1068     1068              
  Lines          31644    31648       +4     
  Branches        3240     3240              
=============================================
- Hits           20278    20275       -3     
- Misses         10094    10103       +9     
+ Partials        1272     1270       -2     
Files Coverage Δ
...os/plugin/auth/impl/controller/UserController.java 12.00% <0.00%> (-0.68%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb1b65...a1b2c71. Read the comment docs.

@KomachiSion KomachiSion added plugin kind/bug Category issues or prs related to bug. labels Jan 11, 2024
@KomachiSion KomachiSion added this to the 2.3.1 milestone Jan 11, 2024
@KomachiSion KomachiSion merged commit a7d1c35 into alibaba:develop Jan 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug. plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nacos server 2.3.0修改用户密码错误
3 participants