Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Warning: Each child in a list should have a unique "key" prop #10742

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

maoling
Copy link
Contributor

@maoling maoling commented Jul 6, 2023

  • fix the warnings: Each child in a list should have a unique "key" prop in the nacos admin UI console

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #10742 (457235c) into develop (a704835) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10742      +/-   ##
=============================================
- Coverage      53.66%   53.64%   -0.03%     
- Complexity      5520     5525       +5     
=============================================
  Files            897      897              
  Lines          28885    28885              
  Branches        3181     3181              
=============================================
- Hits           15502    15494       -8     
- Misses         12029    12033       +4     
- Partials        1354     1358       +4     

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a704835...457235c. Read the comment docs.

@KomachiSion KomachiSion merged commit 8bb957d into alibaba:develop Jul 10, 2023
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. area/Nacos console Related to Nacos consle labels Jul 10, 2023
@KomachiSion KomachiSion added this to the 2.3.0 milestone Jul 10, 2023
lowezheng added a commit to lowezheng/nacos that referenced this pull request Jul 11, 2023
* develop:
  Refactor grpc tls (alibaba#10759)
  dump change check task submit (alibaba#10755)
  [ISSUE alibaba#10734] Implement http request param check filter and http param extractors (alibaba#10758)
  nacos ui doc update to v2 (alibaba#10730)
  fix for react unique key warning (alibaba#10742)
  [ISSUE alibaba#10734] Implement grpc server interceptor and grpc param extractors (alibaba#10745)
  improvements for leave node api and UI (alibaba#10748)
  Delete client version (alibaba#10754)
wukong121 pushed a commit to wukong121/nacos that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants