Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The implementation of findConfigInfoState is not wrapped through MapperManager #12342

Closed
gongycn opened this issue Jul 12, 2024 · 0 comments · Fixed by #12343
Closed

The implementation of findConfigInfoState is not wrapped through MapperManager #12342

gongycn opened this issue Jul 12, 2024 · 0 comments · Fixed by #12343
Labels
kind/bug Category issues or prs related to bug. plugin

Comments

@gongycn
Copy link
Contributor

gongycn commented Jul 12, 2024

Describe the bug
When implementing extension plugins for databases like Oracle, errors occur during the modification of configurations in the public namespace. This is because the implementation of ExternalConfigInfoPersistServiceImpl#findConfigInfoState uses hardcoded SQL instead of being wrapped through MapperManager.

Expected behavior
wrapped through MapperManager
@gongycn gongycn mentioned this issue Jul 12, 2024
Merged
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. plugin labels Jul 15, 2024
@gongycn gongycn mentioned this issue Aug 1, 2024
Merged
MoritzArena added a commit to MoritzArena/nacos that referenced this issue Aug 7, 2024
@MoritzArena
Fallback to use old hessian(alibaba#12342)
25cc9a0
@KomachiSion KomachiSion reopened this Aug 19, 2024
MoritzArena added a commit to MoritzArena/nacos that referenced this issue Oct 28, 2024
@MoritzArena
Fallback to use old hessian(alibaba#12342)
a78266c
KomachiSion pushed a commit that referenced this issue Dec 5, 2024
@gongycn
[ISSUE #12342]: Improve the retrieval of ConfigInfoState to facilitat…
28548c1 
…e the extension and implementation of databases like Oracle. (#12343)

* Improve the retrieval of ConfigInfoState to facilitate the extension and implementation of databases like Oracle.

* Add unit tests for the SQL construction part of the `ExternalConfigInfoPersistServiceImpl#findConfigInfoState` method.

* Enhance the construction of the delete statement in AbstractMapper by using a unified appendWhereClause method to construct the WHERE clause. Modify appendWhereClause to be protected, allowing for customization based on different database types, such as adjustments according to column names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Category issues or prs related to bug. plugin
Projects
None yet
Milestone
No milestone
2 participants
@gongycn @KomachiSion