Resolving PMD warnings.

alibaba · Nov 25, 2024 · a36575e · a36575e
1 parent c8d964d
commit a36575e
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 3 deletions.
diff --git a/config/src/main/java/com/alibaba/nacos/config/server/controller/ConfigServletInner.java b/config/src/main/java/com/alibaba/nacos/config/server/controller/ConfigServletInner.java
@@ -168,7 +168,7 @@ private ConfigQueryChainRequest buildChainRequest(HttpServletRequest request, St
             String tenant, String tag, String clientIp) {
         ConfigQueryChainRequest chainRequest = new ConfigQueryChainRequest();
 
-        Map<String, String> appLabels = new HashMap<>();
+        Map<String, String> appLabels = new HashMap<>(4);
         String autoTag = request.getHeader(VIPSERVER_TAG);
         appLabels.put(BetaGrayRule.CLIENT_IP_LABEL, clientIp);
         if (StringUtils.isNotBlank(tag)) {

diff --git a/config/src/main/java/com/alibaba/nacos/config/server/enums/ApiVersionEnum.java b/config/src/main/java/com/alibaba/nacos/config/server/enums/ApiVersionEnum.java
@@ -22,8 +22,14 @@
  */
 public enum ApiVersionEnum {
 
+    /**
+     * API version v1.
+     */
     V1("v1"),
 
+    /**
+     * API version v2.
+     */
     V2("v2");
 
     private final String version;

diff --git a/config/src/main/java/com/alibaba/nacos/config/server/model/ConfigQueryChainResponse.java b/config/src/main/java/com/alibaba/nacos/config/server/model/ConfigQueryChainResponse.java
@@ -39,11 +39,34 @@ public class ConfigQueryChainResponse {
     private ConfigQueryStatus status;
 
     public enum ConfigQueryStatus {
+        /**
+         * GrayRule-Beta Type.
+         */
         BETA,
+
+        /**
+         * GrayRule-Tag Type.
+         */
         TAG,
+
+        /**
+         * Tag not found.
+         */
         TAG_NOT_FOUND,
+
+        /**
+         * Formal.
+         */
         FORMAL,
+
+        /**
+         * Configuration query conflict.
+         */
         CONFIG_QUERY_CONFLICT,
+
+        /**
+         * Configuration not found.
+         */
         CONFIG_NOT_FOUND,
     }
 

diff --git a/config/src/main/java/com/alibaba/nacos/config/server/remote/ConfigQueryRequestHandler.java b/config/src/main/java/com/alibaba/nacos/config/server/remote/ConfigQueryRequestHandler.java
@@ -157,7 +157,7 @@ public ConfigQueryChainRequest buildChainRequest(ConfigQueryRequest request, Req
         ConfigQueryChainRequest chainRequest = new ConfigQueryChainRequest();
 
         String tag = request.getTag();
-        Map<String, String> appLabels = new HashMap<>();
+        Map<String, String> appLabels = new HashMap<>(4);
         appLabels.put(BetaGrayRule.CLIENT_IP_LABEL, meta.getClientIp());
         if (StringUtils.isNotBlank(tag)) {
             appLabels.put(TagGrayRule.VIP_SERVER_TAG_LABEL, tag);

diff --git a/...ain/java/com/alibaba/nacos/config/server/remote/query/ConfigQueryHandlerChainBuilder.java b/...ain/java/com/alibaba/nacos/config/server/remote/query/ConfigQueryHandlerChainBuilder.java
@@ -24,8 +24,16 @@
  */
 public interface ConfigQueryHandlerChainBuilder {
 
+    /**
+     * Builds the configuration query handler chain.
+     * @return the configuration query handler chain
+     */
     ConfigQueryHandlerChain build();
 
+    /**
+     * Adds a configuration query handler to the chain.
+     * @param handler the handler to be added
+     * @return the current builder instance
+     */
     ConfigQueryHandlerChainBuilder addHandler(ConfigQueryHandler handler);
-
 }