Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SymLinkName, PidFileName, and AgentPrefix support logtail_mode. #1904

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

quzard
Copy link
Collaborator

@quzard quzard commented Nov 21, 2024

This pull request introduces several new utility methods and constants to the AppConfig class in the core/app_config module. These changes aim to enhance the configuration management and file naming conventions based on the logtail_mode flag.

Key changes include:

New utility methods in AppConfig:

  • Added GetSymLinkName method to determine the symbolic link name based on the logtail_mode flag.
  • Added GetPidFileName method to generate the PID file name depending on the logtail_mode flag.
  • Added GetAgentPrefix method to return the appropriate prefix for the agent based on the logtail_mode flag.

Header file updates:

  • Declared the new utility methods (GetSymLinkName, GetPidFileName, and GetAgentPrefix) in core/app_config/AppConfig.h.

Constants definition:

  • Introduced LOONGCOLLECTOR_PREFIX constant in core/common/version.h to support the new methods.

Additional includes:

  • Included common/version.h in core/app_config/AppConfig.cpp to access the newly defined constants.

@quzard quzard changed the title Feat/logtail mode new SymLinkName, PidFileName, and AgentPrefix support logtail_mode. Nov 21, 2024
@quzard quzard merged commit 0ff6f89 into alibaba:main Nov 25, 2024
14 of 15 checks passed
@henryzhx8 henryzhx8 added the enhancement Feature enhancement label Nov 25, 2024
@henryzhx8 henryzhx8 modified the milestones: v2.1, v2.0, v3.0 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants