Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish pipelineEvent and pipelineEventPtr class to improve performance #1368

Merged
merged 8 commits into from
Mar 1, 2024

Conversation

henryzhx8
Copy link
Collaborator

  1. 同一PipelineEventGroup中的所有PipelineEvent共享同一个SourceBuffer,因此取消PipelinEvent类中的mSourceBuffer成员,新增mPipelineEventGroup成员记录事件对应的Group。这样能够显著降低PipelineEvent创建和销毁时的效率,因为原有的mSourceBuffer是个shared_ptr,在创建和销毁时会占用一定时间。
  2. 将PipelineEventPtr中的mData成员类型从shared_ptr改成unique_ptr,效率提升原因同上。

@yyuuttaaoo yyuuttaaoo added the enhancement Feature enhancement label Mar 1, 2024
@yyuuttaaoo yyuuttaaoo merged commit eceb020 into main Mar 1, 2024
18 checks passed
@yyuuttaaoo yyuuttaaoo added this to the v2.0 milestone Mar 27, 2024
@henryzhx8 henryzhx8 deleted the fix/event branch April 2, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants