Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

使用内部类数组作为方法参数时，方法无法被增强 #107

Closed
Benjar opened this issue Oct 26, 2018 · 2 comments
Closed

使用内部类数组作为方法参数时，方法无法被增强 #107

Benjar opened this issue Oct 26, 2018 · 2 comments
Assignees
@oldmanpushcart @dongchenxu
Labels
bug

Comments

@Benjar
Copy link

Benjar commented Oct 26, 2018

目标方法如下： test2和test3方法参数中含有一个内部枚举类数组
wechatimg449

rewrite method之前校验方法的signcode不相同，导致该方法无法被重写，增强不生效
wechatimg445

原因：
com.alibaba.jvm.sandbox.core.util.matcher.structure.ClassStructureImplByJDK#getJavaClassName
com.alibaba.jvm.sandbox.core.enhance.weaver.asm.EventWeaver#getBehaviorSignCode
处理数组类型的class时逻辑不一致
oldmanpushcart added a commit that referenced this issue Oct 27, 2018
@oldmanpushcart
解决问题：#107
a1f928a
@dongchenxu
Copy link
Collaborator

确认是BUG，需要一个比较长的时间进行修复。重点是梳理和重构ClassStructureImplByAsm的逻辑和架构。

@dongchenxu dongchenxu added the bug label Oct 27, 2018
oldmanpushcart added a commit that referenced this issue Nov 6, 2018
@oldmanpushcart
修复问题#107
df2960d
@dongchenxu dongchenxu mentioned this issue Nov 8, 2018
Merged
@dongchenxu
Copy link
Collaborator

问题已修复，且已补充测试用例

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oldmanpushcart oldmanpushcart

@dongchenxu dongchenxu

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oldmanpushcart @dongchenxu @Benjar