Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for use through jvm -javaagent command line option #289

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

jkorri
Copy link
Contributor

@jkorri jkorri commented Sep 6, 2024

I'd like to use the library for various testing scenarios so that I don't have to add a dependency to the project I'm testing, or try to manipulate a running jvm before dns dependent code gets run. This can be achieved by running the agent at JVM startup.

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.75%. Comparing base (72c8073) to head (390860e).

Files with missing lines Patch % Lines
.../src/main/java/com/alibaba/dcm/agent/DcmAgent.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #289      +/-   ##
============================================
+ Coverage     75.26%   75.75%   +0.48%     
- Complexity      162      164       +2     
============================================
  Files            11       11              
  Lines           651      664      +13     
  Branches         84       84              
============================================
+ Hits            490      503      +13     
  Misses          119      119              
  Partials         42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkorri jkorri force-pushed the allow_use_through_jvm_option branch 2 times, most recently from d89230e to 097ca8f Compare September 6, 2024 17:37
@oldratlee oldratlee self-requested a review September 8, 2024 12:36
@jkorri jkorri force-pushed the allow_use_through_jvm_option branch from 097ca8f to 390860e Compare September 9, 2024 06:35
@oldratlee oldratlee self-assigned this Sep 9, 2024
Copy link
Member

@oldratlee oldratlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


@jkorri Thanks for your professional contributions, merged 💕

@oldratlee oldratlee merged commit db7a179 into alibaba:main Sep 9, 2024
16 checks passed
@oldratlee
Copy link
Member

@jkorri released v1.8.3:
https://github.com/alibaba/java-dns-cache-manipulator/releases/tag/v1.8.3

@jkorri jkorri deleted the allow_use_through_jvm_option branch September 10, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants