Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(antd): fix form item overflow tooltip abnormal show with container zoomed #4189

Closed

Conversation

Del-te
Copy link

@Del-te Del-te commented Jul 18, 2024

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

fix Formily-Ant-FormItem-useOverflow judge error when container zoom

form item overflow tooltip will abnormal show when container is zooming, error case: using formily in antd@4 Modal, antd@4 Modal has a zoom animation, it cause overflow judging error in form-item label-render,becase overflow judging only once。

Formily里的form item的label如果overflow的话有个tooltip,但是判断overflow的方法只判断了一次,如果Formily的外层容器缩放过,overflow判断就不准了,表现是label的tooltip出现与否完全没有规律。antd@4 的modal打开动画就是缩放,在antd@4的modal里使用Formily就有这个问题

image

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


jialiwei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Del-te Del-te changed the title fix(antd): fix form item overflow tooltip abnormal with container zoomed fix(antd): fix form item overflow tooltip abnormal show with container zoomed Jul 18, 2024
@Del-te Del-te closed this Jul 18, 2024
@Del-te Del-te deleted the bugfix-form-item-overflow-tooltip branch July 18, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants