Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix form fields query throw error #3992

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

janryWang
Copy link
Collaborator

@janryWang janryWang commented Oct 17, 2023

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Fixed #3932

@github-actions
Copy link
Contributor

Size Change: +26 B (0%)

Total Size: 516 kB

Filename Size Change
packages/core/dist/formily.core.umd.development.js 20.6 kB +16 B (0%)
packages/core/dist/formily.core.umd.production.js 13.3 kB +10 B (0%)
ℹ️ View Unchanged
Filename Size
packages/antd/dist/formily.antd.umd.development.js 86 kB
packages/antd/dist/formily.antd.umd.production.js 47.4 kB
packages/element/dist/formily.element.umd.development.js 63 kB
packages/element/dist/formily.element.umd.production.js 35.9 kB
packages/grid/dist/formily.grid.umd.development.js 9.13 kB
packages/grid/dist/formily.grid.umd.production.js 5.67 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 7.21 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.58 kB
packages/next/dist/formily.next.umd.development.js 78.7 kB
packages/next/dist/formily.next.umd.production.js 45.2 kB
packages/path/dist/formily.path.umd.development.js 11.3 kB
packages/path/dist/formily.path.umd.production.js 7.27 kB
packages/react/dist/formily.react.umd.development.js 6.51 kB
packages/react/dist/formily.react.umd.production.js 3.87 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 4.28 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.03 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 3.11 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.34 kB
packages/reactive/dist/formily.reactive.umd.development.js 9.68 kB
packages/reactive/dist/formily.reactive.umd.production.js 5.43 kB
packages/shared/dist/formily.shared.umd.development.js 8.05 kB
packages/shared/dist/formily.shared.umd.production.js 4.09 kB
packages/validator/dist/formily.validator.umd.development.js 8.56 kB
packages/validator/dist/formily.validator.umd.production.js 5.84 kB
packages/vue/dist/formily.vue.umd.development.js 11.1 kB
packages/vue/dist/formily.vue.umd.production.js 6.38 kB

compressed-size-action

@janryWang janryWang merged commit 7477519 into formily_next Oct 17, 2023
@janryWang janryWang deleted the fix_form_fields_query_throw_error branch October 17, 2023 13:33
@@ -45,6 +45,10 @@ export class Query {
}
} else {
each(this.form.fields, (field, address) => {
if (!field) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

虽然这样修复了这个问题, 但为什么不采用 https://github.com/alibaba/formily/pull/3987/files 在 undefined 产生的源头尽快修复的方案, 在这里修复有种头痛医头脚痛医脚的感觉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

痛哭流涕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] ArrayField method will throw error and break
3 participants