Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(element): fix opened name writing error #3695

Conversation

ZhiLinLiang
Copy link
Contributor

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

修复 element-uiform-dialogform-drawer 组件的 opened 事件名称书写错误,导致组件事件失效的问题。

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 96.57% // Head: 96.57% // No change to project coverage 👍

Coverage data is based on head (7e54341) compared to base (1b809a3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           formily_next    #3695   +/-   ##
=============================================
  Coverage         96.57%   96.57%           
=============================================
  Files               152      152           
  Lines              6603     6603           
  Branches           1836     1835    -1     
=============================================
  Hits               6377     6377           
+ Misses              226      199   -27     
- Partials              0       27   +27     
Impacted Files Coverage Δ
packages/path/src/index.ts 68.69% <0.00%> (ø)
packages/path/src/parser.ts 92.42% <0.00%> (ø)
packages/path/src/shared.ts 50.87% <0.00%> (ø)
packages/vue/src/shared/h.ts 86.48% <0.00%> (ø)
packages/path/src/tokenizer.ts 91.74% <0.00%> (ø)
packages/core/src/models/Field.ts 99.07% <0.00%> (ø)
packages/reactive/src/internals.ts 95.12% <0.00%> (ø)
packages/vue/src/components/ReactiveField.ts 100.00% <0.00%> (ø)
packages/reactive/src/handlers.ts 98.73% <0.00%> (+0.02%) ⬆️
...ckages/reactive-vue/src/observer/observerInVue2.ts 96.49% <0.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZhiLinLiang
Copy link
Contributor Author

ZhiLinLiang commented Feb 3, 2023 via email

@janryWang janryWang merged commit c616bf1 into alibaba:formily_next Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants