Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(element): fix Checkbox.Group's change event failure #3667

Merged

Conversation

ZhiLinLiang
Copy link
Contributor

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

fix Checkbox.Group's change event is triggered twice, Cause functional failure.
修复多选框组选项勾选失败问题。

具体原因

Checkbox.Group组件一次点击而触发两次 change 事件并且两次chang事件获得的值不一致,所以导致切换失败。 可以参考 #3665

fix Checkbox.Group's change event is triggered twice, Cause functional failure.
修复多选框组选项勾选失败问题。
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 96.57% // Head: 96.57% // No change to project coverage 👍

Coverage data is based on head (499515c) compared to base (1b809a3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           formily_next    #3667   +/-   ##
=============================================
  Coverage         96.57%   96.57%           
=============================================
  Files               152      152           
  Lines              6603     6603           
  Branches           1836     1836           
=============================================
  Hits               6377     6377           
  Misses              226      226           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@janryWang janryWang merged commit 2bfa40c into alibaba:formily_next Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants