Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): revert initial values check logic #3642

Merged
merged 1 commit into from
Dec 25, 2022

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

revert https://github.com/alibaba/formily/pull/3583/files

原因:从时序关系来看,createForm 创建的默认值是在 createField 创建默认值之前,存在冲突的策略是,先赋值的要被后赋值的覆盖,所以原有逻辑没有任何问题

@codecov
Copy link

codecov bot commented Dec 25, 2022

Codecov Report

Base: 96.35% // Head: 96.38% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (7348d60) compared to base (29b799c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           formily_next    #3642      +/-   ##
================================================
+ Coverage         96.35%   96.38%   +0.02%     
================================================
  Files               152      152              
  Lines              6605     6603       -2     
  Branches           1838     1836       -2     
================================================
  Hits               6364     6364              
+ Misses              241      239       -2     
Impacted Files Coverage Δ
packages/core/src/shared/internals.ts 100.00% <ø> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Size Change: -24 B (0%)

Total Size: 550 kB

Filename Size Change
packages/core/dist/formily.core.umd.development.js 20.1 kB -14 B (0%)
packages/core/dist/formily.core.umd.production.js 13.5 kB -10 B (0%)
ℹ️ View Unchanged
Filename Size
packages/antd/dist/formily.antd.umd.development.js 73.7 kB
packages/antd/dist/formily.antd.umd.production.js 41.2 kB
packages/element/dist/formily.element.umd.development.js 76 kB
packages/element/dist/formily.element.umd.production.js 42.8 kB
packages/grid/dist/formily.grid.umd.development.js 9.01 kB
packages/grid/dist/formily.grid.umd.production.js 6.07 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 6.96 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.43 kB
packages/next/dist/formily.next.umd.development.js 78.5 kB
packages/next/dist/formily.next.umd.production.js 45.5 kB
packages/path/dist/formily.path.umd.development.js 11.1 kB
packages/path/dist/formily.path.umd.production.js 7.71 kB
packages/react/dist/formily.react.umd.development.js 6.18 kB
packages/react/dist/formily.react.umd.production.js 3.69 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 4.16 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.46 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 11.8 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 6.06 kB
packages/reactive/dist/formily.reactive.umd.development.js 9.52 kB
packages/reactive/dist/formily.reactive.umd.production.js 5.36 kB
packages/shared/dist/formily.shared.umd.development.js 7.42 kB
packages/shared/dist/formily.shared.umd.production.js 4.3 kB
packages/validator/dist/formily.validator.umd.development.js 8.44 kB
packages/validator/dist/formily.validator.umd.production.js 6.28 kB
packages/vue/dist/formily.vue.umd.development.js 24.6 kB
packages/vue/dist/formily.vue.umd.production.js 13.3 kB

compressed-size-action

@janryWang janryWang merged commit 42be193 into formily_next Dec 25, 2022
@janryWang janryWang deleted the revert_initial_values_check_logic branch December 25, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant