fix(antd): fix Cascader in form readPretty mode display error #3250 #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fengwuxp
commented
Jul 5, 2022
| ?.filter((item) => isValid(item)) | ||
| ?.map((item) => item?.whole?.join('/')) | ||
| .join(', ') | ||
| const values = findSelectedItems(dataSource, selected) |
There was a problem hiding this comment.
为了避免修改 getValueByValue 影响其他组件，重新写了查找选中值的逻辑。
There was a problem hiding this comment.
fusion Cascader readPretty 已修复
测试发现一个新问题：
fusion 的级联选择组件普通模式回填表单值也有问题,参见： demo
回填查找逻辑好像是使用数组的最后一项，要是级联选择最后一个选项有重复（相对上一个选项）的话会就会有问题（参见例子的租户环境级联选中）
Codecov Report
@@ Coverage Diff @@
## formily_next #3253 +/- ##
=============================================
Coverage 96.13% 96.13%
=============================================
Files 152 152
Lines 6580 6580
Branches 1835 1835
=============================================
Hits 6326 6326
Misses 225 225
Partials 29 29 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done...
masterorformily_next.npm test).npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.Please do not delete the above content
see issues Cascader readPretty 模式下回显错误
验证 fix demo