Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactive-react): fix react18 strict mode dispose trigger timing #3229

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Fixed #3219

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #3229 (89435b2) into formily_next (9144235) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           formily_next    #3229   +/-   ##
=============================================
  Coverage         96.14%   96.14%           
=============================================
  Files               152      152           
  Lines              6586     6586           
  Branches           1777     1835   +58     
=============================================
  Hits               6332     6332           
+ Misses              254      225   -29     
- Partials              0       29   +29     
Impacted Files Coverage Δ
packages/path/src/index.ts 65.26% <0.00%> (ø)
packages/path/src/parser.ts 92.42% <0.00%> (ø)
packages/path/src/shared.ts 50.87% <0.00%> (ø)
packages/vue/src/shared/h.ts 86.48% <0.00%> (ø)
packages/path/src/tokenizer.ts 91.74% <0.00%> (ø)
packages/core/src/models/Field.ts 99.05% <0.00%> (ø)
packages/reactive/src/externals.ts 90.58% <0.00%> (ø)
packages/reactive/src/internals.ts 95.12% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9144235...89435b2. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: +32 B (0%)

Total Size: 508 kB

Filename Size Change
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.65 kB +21 B (+1%)
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.28 kB +11 B (0%)
ℹ️ View Unchanged
Filename Size
packages/antd/dist/formily.antd.umd.development.js 71.5 kB
packages/antd/dist/formily.antd.umd.production.js 39.9 kB
packages/core/dist/formily.core.umd.development.js 20 kB
packages/core/dist/formily.core.umd.production.js 13.4 kB
packages/element/dist/formily.element.umd.development.js 63.1 kB
packages/element/dist/formily.element.umd.production.js 36.6 kB
packages/grid/dist/formily.grid.umd.development.js 9.01 kB
packages/grid/dist/formily.grid.umd.production.js 6.07 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 6.96 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.43 kB
packages/next/dist/formily.next.umd.development.js 76.4 kB
packages/next/dist/formily.next.umd.production.js 44.3 kB
packages/path/dist/formily.path.umd.development.js 11.2 kB
packages/path/dist/formily.path.umd.production.js 7.72 kB
packages/react/dist/formily.react.umd.development.js 11.7 kB
packages/react/dist/formily.react.umd.production.js 7.27 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.96 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.87 kB
packages/reactive/dist/formily.reactive.umd.development.js 9.45 kB
packages/reactive/dist/formily.reactive.umd.production.js 5.27 kB
packages/shared/dist/formily.shared.umd.development.js 7.42 kB
packages/shared/dist/formily.shared.umd.production.js 4.3 kB
packages/validator/dist/formily.validator.umd.development.js 8.43 kB
packages/validator/dist/formily.validator.umd.production.js 6.28 kB
packages/vue/dist/formily.vue.umd.development.js 16.5 kB
packages/vue/dist/formily.vue.umd.production.js 9.85 kB

compressed-size-action

@janryWang janryWang merged commit 9182e1f into formily_next Jun 26, 2022
@janryWang janryWang deleted the fix_react18_strict_mode_dispose branch June 26, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] update react18 formily not work
1 participant