Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(antd/next): fix array string field addition logic #2998

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

janryWang
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Fixed #2983

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #2998 (e2c67f6) into formily_next (378496b) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           formily_next    #2998   +/-   ##
=============================================
  Coverage         96.06%   96.06%           
=============================================
  Files               149      149           
  Lines              6488     6488           
  Branches           1750     1750           
=============================================
  Hits               6233     6233           
  Misses              255      255           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378496b...e2c67f6. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: -50 B (0%)

Total Size: 505 kB

Filename Size Change
packages/antd/dist/formily.antd.umd.development.js 71.2 kB -9 B (0%)
packages/antd/dist/formily.antd.umd.production.js 39.8 kB -2 B (0%)
packages/next/dist/formily.next.umd.development.js 76.1 kB -34 B (0%)
packages/next/dist/formily.next.umd.production.js 44.2 kB -5 B (0%)
ℹ️ View Unchanged
Filename Size
packages/core/dist/formily.core.umd.development.js 19.8 kB
packages/core/dist/formily.core.umd.production.js 13.4 kB
packages/element/dist/formily.element.umd.development.js 62.7 kB
packages/element/dist/formily.element.umd.production.js 36.4 kB
packages/grid/dist/formily.grid.umd.development.js 9.01 kB
packages/grid/dist/formily.grid.umd.production.js 6.07 kB
packages/json-schema/dist/formily.json-schema.umd.development.js 6.88 kB
packages/json-schema/dist/formily.json-schema.umd.production.js 4.36 kB
packages/path/dist/formily.path.umd.development.js 11.1 kB
packages/path/dist/formily.path.umd.production.js 7.71 kB
packages/react/dist/formily.react.umd.development.js 11.4 kB
packages/react/dist/formily.react.umd.production.js 7.09 kB
packages/reactive-react/dist/formily.reactive-react.umd.development.js 3.61 kB
packages/reactive-react/dist/formily.reactive-react.umd.production.js 2.25 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.development.js 2.92 kB
packages/reactive-vue/dist/formily.reactive-vue.umd.production.js 1.83 kB
packages/reactive/dist/formily.reactive.umd.development.js 9.32 kB
packages/reactive/dist/formily.reactive.umd.production.js 5.22 kB
packages/shared/dist/formily.shared.umd.development.js 7.22 kB
packages/shared/dist/formily.shared.umd.production.js 4.18 kB
packages/validator/dist/formily.validator.umd.development.js 8.43 kB
packages/validator/dist/formily.validator.umd.production.js 6.28 kB
packages/vue/dist/formily.vue.umd.development.js 16.4 kB
packages/vue/dist/formily.vue.umd.production.js 9.75 kB

compressed-size-action

@janryWang janryWang merged commit 888dc47 into formily_next Mar 30, 2022
@janryWang janryWang deleted the fix_antd_next_addition_logic branch March 30, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] ArrayItems 数组添加时候 default 值无效 回滚到 2.0.14恢复正常
1 participant