Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): improve expression scope #2875

Merged

Conversation

frehaiku
Copy link
Collaborator

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Improve expression scopes in Vue.js

@CLAassistant
Copy link

CLAassistant commented Feb 27, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #2875 (9b292b1) into formily_next (78b5caa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           formily_next    #2875   +/-   ##
=============================================
  Coverage         95.98%   95.99%           
=============================================
  Files               147      148    +1     
  Lines              6355     6364    +9     
  Branches           1712     1712           
=============================================
+ Hits               6100     6109    +9     
  Misses              255      255           
Impacted Files Coverage Δ
packages/vue/src/types/index.ts 75.00% <ø> (ø)
packages/vue/src/components/ExpressionScope.ts 100.00% <100.00%> (ø)
packages/vue/src/components/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b5caa...9b292b1. Read the comment docs.

@janryWang
Copy link
Collaborator

覆盖率没达标,麻烦再优化一下哈

@frehaiku
Copy link
Collaborator Author

done

@janryWang janryWang merged commit 22a3d2b into alibaba:formily_next Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants