Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): add component name in connect #2810

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

zhouxinyong
Copy link
Contributor

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

fix #2807
add component name in connect API

@CLAassistant
Copy link

CLAassistant commented Feb 10, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #2810 (ac3a866) into formily_next (d116d27) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           formily_next    #2810   +/-   ##
=============================================
  Coverage         95.83%   95.83%           
=============================================
  Files               147      147           
  Lines              6344     6344           
  Branches           1763     1711   -52     
=============================================
  Hits               6080     6080           
- Misses              234      264   +30     
+ Partials             30        0   -30     
Impacted Files Coverage Δ
packages/vue/src/shared/connect.ts 100.00% <ø> (ø)
packages/path/src/index.ts 63.75% <0.00%> (ø)
packages/path/src/parser.ts 92.27% <0.00%> (ø)
packages/path/src/shared.ts 50.87% <0.00%> (ø)
packages/path/src/tokenizer.ts 91.74% <0.00%> (ø)
packages/core/src/models/Field.ts 98.55% <0.00%> (ø)
packages/reactive/src/externals.ts 90.58% <0.00%> (ø)
packages/reactive/src/internals.ts 95.06% <0.00%> (ø)
packages/vue/src/components/RecursionField.ts 95.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d116d27...ac3a866. Read the comment docs.

@janryWang janryWang merged commit 5a695c0 into alibaba:formily_next Feb 10, 2022
@zhouxinyong zhouxinyong deleted the fix-vue-connect branch February 10, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants