correct and improve typescript definitions #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stkevintan
requested review from
atzcl,
monkindey and
janryWang
and removed request for
atzcl
janryWang
reviewed
Aug 20, 2019
packages/next/src/index.tsx
Outdated
| type?: T | ||
| name?: string | ||
| editable?: boolean | ||
| ['x-props']?: T extends keyof InternalFieldTypes ? InternalFieldTypes[T] : any |
There was a problem hiding this comment.
这里的所有类型，能不能挪到./types.ts里去，全部放在一起，不方便维护
janryWang
reviewed
Aug 20, 2019
packages/core/src/form.ts
Outdated
| return | ||
| } | ||
| const published = this.publishState() | ||
| reducer(published, reducer) | ||
| callback(published, callback) |
There was a problem hiding this comment.
这里有bug，不应该再传callback进去，应该是我当时写的手误
There was a problem hiding this comment.
这里我看到的时候也比较疑惑，原来如此
janryWang
reviewed
Aug 20, 2019
| @@ -85,6 +85,8 @@ export class Form { | |||
| private traverse: (schema: ISchema) => ISchema | |||
|
|
|||
| constructor(opts: IFormOptions) { | |||
| this.getFieldState = this.getFieldState.bind(this) | |||
| this.getFormState = this.getFormState.bind(this) | |||
| this.options = defaults<IFormOptions>(opts) | |||
There was a problem hiding this comment.
箭头函数是property不是method，不能重载
There was a problem hiding this comment.
能不能不用重载，用bind的形式，感觉不够优雅😂
janryWang
reviewed
Aug 20, 2019
packages/antd/src/index.tsx
Outdated
| import { TimePickerProps } from 'antd/lib/time-picker' | ||
| import { TransferProps } from 'antd/lib/transfer' | ||
| import { IUploaderProps } from './fields/upload' | ||
| import { SelectProps } from 'antd/lib/select' | ||
|
|
There was a problem hiding this comment.
将依赖的类型统一放到./types.ts中吧，不然很难维护
atzcl
reviewed
Aug 21, 2019
| wrapperCol?: ColProps | number | ||
| labelCol?: ColProps | number | ||
| labelTextAlign?: TextAlign | ||
| size?: Size | ||
| style?: React.CSSProperties | ||
| } | ||
|
|
||
| export interface IFormItemGridProps { | ||
| cols?: Array<number | { span: number; offset: number }> |
There was a problem hiding this comment.
cols?: Array<number | { span: number; offset: number }>
改成
cols?: (number | ColSize)[]
会不会好点？
anyuxuan
pushed a commit
to anyuxuan/uform
that referenced
this pull request
Nov 14, 2019
ZirkleTsing
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IFormActionandIAsyncFormActiontypesSchemaFormtype definitions add types forFieldx-propstype infer ofFieldwhen type is internal