fix(@uform/react): invariant initialValues will not be changed when form rerender #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janryWang
reviewed
Jul 30, 2019
packages/react/src/state/form.tsx
Outdated
| @@ -182,17 +182,24 @@ export const StateForm = createHOC((options, Form) => { | |||
| } | |||
|
|
|||
| public componentDidUpdate(prevProps) { | |||
| const { value, editable, initialValues } = this.props | |||
| const { value, editable, initialValues, schema } = this.props | |||
| const calculatedInitialValues = caculateSchemaInitialValues( | |||
There was a problem hiding this comment.
为什么只计算当前props的intialValues，不计算prevProps的intialValues？
There was a problem hiding this comment.
这里不用任何改动，仔细看一下，其实是props.initialValues引用被改动了，只需要在
https://github.com/alibaba/uform/blob/master/packages/core/src/index.ts#L30 加上clone即可，我们只需要每次对比的都是props就行了
There was a problem hiding this comment.
values 要不要也 clone 一份？
atzcl
reviewed
Jul 31, 2019
| @@ -121,7 +121,7 @@ export const caculateSchemaInitialValues = ( | |||
| if (!isEmpty(value)) { | |||
| setIn(initialValues, name, value) | |||
| } | |||
| if (isFn(callback)) { | |||
| if (callback && isFn(callback)) { | |||
There was a problem hiding this comment.
isFn 方法的通过不是确保了 callback 会是 Function 嘛，这样还需要再先确保 callback 是存在的吗？
There was a problem hiding this comment.
如果没有的话就不要执行 isFn 了。
…hen form rerender
monkindey
changed the title
ZirkleTsing
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #211
原因在于 initialValues 在 componentDidUpdate 的时候没有收集 schema 的 default，导致 initialValues 不一致。原因是 #214 (comment)